WordPress.org

Make WordPress Core


Ignore:
Timestamp:
07/09/2019 05:44:42 AM (5 months ago)
Author:
pento
Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

  • The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
  • Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
  • Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
  • Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/default-constants.php

    r45203 r45611  
    3535    }
    3636
    37     $current_limit     = @ini_get( 'memory_limit' );
     37    $current_limit     = ini_get( 'memory_limit' );
    3838    $current_limit_int = wp_convert_hr_to_bytes( $current_limit );
    3939
     
    6262    $wp_limit_int = wp_convert_hr_to_bytes( WP_MEMORY_LIMIT );
    6363    if ( -1 !== $current_limit_int && ( -1 === $wp_limit_int || $wp_limit_int > $current_limit_int ) ) {
    64         @ini_set( 'memory_limit', WP_MEMORY_LIMIT );
     64        ini_set( 'memory_limit', WP_MEMORY_LIMIT );
    6565    }
    6666
Note: See TracChangeset for help on using the changeset viewer.