Changeset 45611 for trunk/src/wp-includes/formatting.php

Timestamp:

07/09/2019 05:44:42 AM (5 years ago)

Author:

pento

Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

• The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
• Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
• Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
• Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:

• trunk/src/wp-includes/formatting.php (modified) (3 diffs)

trunk/src/wp-includes/formatting.php

@@ -995 +995 @@
     }
 
-    $string = @htmlspecialchars( $string, $quote_style, $charset, $double_encode );
+    $string = htmlspecialchars( $string, $quote_style, $charset, $double_encode );
 
     // Back-compat.
@@ -1130 +1130 @@
     static $utf8_pcre = null;
     if ( ! isset( $utf8_pcre ) ) {
+        // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged
         $utf8_pcre = @preg_match( '/^./u', 'a' );
     }
@@ -1137 +1138 @@
     }
 
-    // preg_match fails when it encounters invalid UTF8 in $string
+    // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged -- preg_match fails when it encounters invalid UTF8 in $string
     if ( 1 === @preg_match( '/^./us', $string ) ) {
         return $string;