WordPress.org

Make WordPress Core


Ignore:
Timestamp:
07/09/2019 05:44:42 AM (8 months ago)
Author:
pento
Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

  • The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
  • Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
  • Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
  • Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/formatting.php

    r45602 r45611  
    995995    }
    996996
    997     $string = @htmlspecialchars( $string, $quote_style, $charset, $double_encode );
     997    $string = htmlspecialchars( $string, $quote_style, $charset, $double_encode );
    998998
    999999    // Back-compat.
     
    11301130    static $utf8_pcre = null;
    11311131    if ( ! isset( $utf8_pcre ) ) {
     1132        // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged
    11321133        $utf8_pcre = @preg_match( '/^./u', 'a' );
    11331134    }
     
    11371138    }
    11381139
    1139     // preg_match fails when it encounters invalid UTF8 in $string
     1140    // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged -- preg_match fails when it encounters invalid UTF8 in $string
    11401141    if ( 1 === @preg_match( '/^./us', $string ) ) {
    11411142        return $string;
Note: See TracChangeset for help on using the changeset viewer.