WordPress.org

Make WordPress Core


Ignore:
Timestamp:
07/09/2019 05:44:42 AM (9 months ago)
Author:
pento
Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

  • The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
  • Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
  • Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
  • Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/http.php

    r42894 r45611  
    497497
    498498    if ( is_allowed_http_origin( $origin ) ) {
    499         @header( 'Access-Control-Allow-Origin: ' . $origin );
    500         @header( 'Access-Control-Allow-Credentials: true' );
     499        header( 'Access-Control-Allow-Origin: ' . $origin );
     500        header( 'Access-Control-Allow-Credentials: true' );
    501501        if ( 'OPTIONS' === $_SERVER['REQUEST_METHOD'] ) {
    502502            exit;
Note: See TracChangeset for help on using the changeset viewer.