Changeset 45611 for trunk/src/wp-includes/load.php

Timestamp:

07/09/2019 05:44:42 AM (5 years ago)

Author:

pento

Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

• The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
• Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
• Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
• Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:

• trunk/src/wp-includes/load.php (modified) (2 diffs)

trunk/src/wp-includes/load.php

@@ -353 +353 @@
 
     if ( defined( 'XMLRPC_REQUEST' ) || defined( 'REST_REQUEST' ) || ( defined( 'WP_INSTALLING' ) && WP_INSTALLING ) || wp_doing_ajax() || wp_is_json_request() ) {
-        @ini_set( 'display_errors', 0 );
+        ini_set( 'display_errors', 0 );
     }
 }
@@ -909 +909 @@
     if ( function_exists( 'mb_internal_encoding' ) ) {
         $charset = get_option( 'blog_charset' );
+        // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged
         if ( ! $charset || ! @mb_internal_encoding( $charset ) ) {
             mb_internal_encoding( 'UTF-8' );