WordPress.org

Make WordPress Core


Ignore:
Timestamp:
07/09/2019 05:44:42 AM (8 months ago)
Author:
pento
Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

  • The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
  • Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
  • Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
  • Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/media.php

    r45541 r45611  
    239239
    240240        if ( $thumb_file ) {
    241             $info = getimagesize( $thumb_file );
     241            $info = @getimagesize( $thumb_file );
    242242        }
    243243
     
    911911                $icon_dir = apply_filters( 'icon_dir', ABSPATH . WPINC . '/images/media' );
    912912
    913                 $src_file                = $icon_dir . '/' . wp_basename( $src );
    914                 @list( $width, $height ) = getimagesize( $src_file );
     913                $src_file               = $icon_dir . '/' . wp_basename( $src );
     914                list( $width, $height ) = @getimagesize( $src_file );
    915915            }
    916916        }
Note: See TracChangeset for help on using the changeset viewer.