Changeset 45611 for trunk/src/wp-includes/pluggable.php

Timestamp:

07/09/2019 05:44:42 AM (7 years ago)

Author:

pento

Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

• The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
• Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
• Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
• Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:

• trunk/src/wp-includes/pluggable.php (modified) (5 diffs)

trunk/src/wp-includes/pluggable.php

@@ -1523 +1523 @@
         $switched_locale = switch_to_locale( get_locale() );
 
-        $comment_author_domain = @gethostbyaddr( $comment->comment_author_IP );
+        $comment_author_domain = '';
+        if ( WP_Http::is_ip_address( $comment->comment_author_IP ) ) {
+            $comment_author_domain = gethostbyaddr( $comment->comment_author_IP );
+        }
 
         // The blogname option is escaped with esc_html on the way into the database in sanitize_option
@@ -1640 +1643 @@
 
         foreach ( $emails as $email ) {
-            @wp_mail( $email, wp_specialchars_decode( $subject ), $notify_message, $message_headers );
+            wp_mail( $email, wp_specialchars_decode( $subject ), $notify_message, $message_headers );
         }
 
@@ -1697 +1700 @@
         $switched_locale = switch_to_locale( get_locale() );
 
-        $comment_author_domain = @gethostbyaddr( $comment->comment_author_IP );
-        $comments_waiting      = $wpdb->get_var( "SELECT count(comment_ID) FROM $wpdb->comments WHERE comment_approved = '0'" );
+        $comment_author_domain = '';
+        if ( WP_Http::is_ip_address( $comment->comment_author_IP ) ) {
+            $comment_author_domain = gethostbyaddr( $comment->comment_author_IP );
+        }
+
+        $comments_waiting = $wpdb->get_var( "SELECT count(comment_ID) FROM $wpdb->comments WHERE comment_approved = '0'" );
 
         // The blogname option is escaped with esc_html on the way into the database in sanitize_option
@@ -1811 +1818 @@
 
         foreach ( $emails as $email ) {
-            @wp_mail( $email, wp_specialchars_decode( $subject ), $notify_message, $message_headers );
+            wp_mail( $email, wp_specialchars_decode( $subject ), $notify_message, $message_headers );
         }
 
@@ -1948 +1955 @@
             $wp_new_user_notification_email_admin = apply_filters( 'wp_new_user_notification_email_admin', $wp_new_user_notification_email_admin, $user, $blogname );
 
-            @wp_mail(
+            wp_mail(
                 $wp_new_user_notification_email_admin['to'],
                 wp_specialchars_decode( sprintf( $wp_new_user_notification_email_admin['subject'], $blogname ) ),