WordPress.org

Make WordPress Core


Ignore:
Timestamp:
07/09/2019 05:44:42 AM (7 months ago)
Author:
pento
Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

  • The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
  • Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
  • Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
  • Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rest-api/class-wp-rest-server.php

    r45566 r45611  
    12801280     */
    12811281    public function remove_header( $key ) {
    1282         if ( function_exists( 'header_remove' ) ) {
    1283             // In PHP 5.3+ there is a way to remove an already set header.
    1284             header_remove( $key );
    1285         } else {
    1286             // In PHP 5.2, send an empty header, but only as a last resort to
    1287             // override a header already sent.
    1288             foreach ( headers_list() as $header ) {
    1289                 if ( 0 === stripos( $header, "$key:" ) ) {
    1290                     $this->send_header( $key, '' );
    1291                     break;
    1292                 }
    1293             }
    1294         }
     1282        header_remove( $key );
    12951283    }
    12961284
Note: See TracChangeset for help on using the changeset viewer.