Changeset 45611 for trunk/src/wp-includes/wp-db.php

Timestamp:

07/09/2019 05:44:42 AM (5 years ago)

Author:

pento

Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

• The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
• Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
• Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
• Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:

• trunk/src/wp-includes/wp-db.php (modified) (3 diffs)

trunk/src/wp-includes/wp-db.php

@@ -1377 +1377 @@
 
         array_walk( $args, array( $this, 'escape_by_ref' ) );
-        $query = @vsprintf( $query, $args );
+        $query = vsprintf( $query, $args );
 
         return $this->add_placeholder_escape( $query );
@@ -1615 +1615 @@
                 mysqli_real_connect( $this->dbh, $host, $this->dbuser, $this->dbpassword, null, $port, $socket, $client_flags );
             } else {
+                // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged
                 @mysqli_real_connect( $this->dbh, $host, $this->dbuser, $this->dbpassword, null, $port, $socket, $client_flags );
             }
@@ -1646 +1647 @@
                 $this->dbh = mysql_connect( $this->dbhost, $this->dbuser, $this->dbpassword, $new_link, $client_flags );
             } else {
+                // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged
                 $this->dbh = @mysql_connect( $this->dbhost, $this->dbuser, $this->dbpassword, $new_link, $client_flags );
             }