WordPress.org

Make WordPress Core


Ignore:
Timestamp:
07/09/2019 05:44:42 AM (9 months ago)
Author:
pento
Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

  • The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
  • Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
  • Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
  • Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/wp-db.php

    r45602 r45611  
    13771377
    13781378        array_walk( $args, array( $this, 'escape_by_ref' ) );
    1379         $query = @vsprintf( $query, $args );
     1379        $query = vsprintf( $query, $args );
    13801380
    13811381        return $this->add_placeholder_escape( $query );
     
    16151615                mysqli_real_connect( $this->dbh, $host, $this->dbuser, $this->dbpassword, null, $port, $socket, $client_flags );
    16161616            } else {
     1617                // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged
    16171618                @mysqli_real_connect( $this->dbh, $host, $this->dbuser, $this->dbpassword, null, $port, $socket, $client_flags );
    16181619            }
     
    16461647                $this->dbh = mysql_connect( $this->dbhost, $this->dbuser, $this->dbpassword, $new_link, $client_flags );
    16471648            } else {
     1649                // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged
    16481650                $this->dbh = @mysql_connect( $this->dbhost, $this->dbuser, $this->dbpassword, $new_link, $client_flags );
    16491651            }
Note: See TracChangeset for help on using the changeset viewer.