Changeset 45624

Timestamp:

07/11/2019 11:50:37 PM (5 years ago)

Author:

pento

Message:

Code Modernisation: Introduce the spread operator in Walker.

Rather than relying func_get_args() to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.

File:

• trunk/src/wp-includes/class-wp-walker.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-walker.php

@@ -185 +185 @@
      * @param array $elements  An array of elements.
      * @param int   $max_depth The maximum hierarchical depth.
+     * @param mixed ...$args   Optional additional arguments.
      * @return string The hierarchical item output.
      */
-    public function walk( $elements, $max_depth ) {
-        $args   = array_slice( func_get_args(), 2 );
+    public function walk( $elements, $max_depth, ...$args ) {
         $output = '';
 
@@ -277 +277 @@
      * @param array $elements
      * @param int   $max_depth The maximum hierarchical depth.
-     * @param int   $page_num The specific page number, beginning with 1.
+     * @param int   $page_num  The specific page number, beginning with 1.
      * @param int   $per_page
+     * @param mixed ...$args   Optional additional arguments.
      * @return string XHTML of the specified page of elements
      */
-    public function paged_walk( $elements, $max_depth, $page_num, $per_page ) {
+    public function paged_walk( $elements, $max_depth, $page_num, $per_page, ...$args ) {
         if ( empty( $elements ) || $max_depth < -1 ) {
             return '';
         }
 
-        $args   = array_slice( func_get_args(), 4 );
         $output = '';