Changeset 45629 for trunk/src/wp-includes/widgets.php

Timestamp:

07/12/2019 12:13:07 AM (6 years ago)

Author:

pento

Message:

Code Modernisation: Introduce the spread operator in widgets.php.

Rather than relying func_get_args() to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.

File:

• trunk/src/wp-includes/widgets.php (modified) (7 diffs)

trunk/src/wp-includes/widgets.php

@@ -459 +459 @@
  * @since 2.2.0
  *
- * @todo `$params` parameter?
- *
  * @global array $wp_registered_widget_controls
  * @global array $wp_registered_widget_updates
@@ -480 +478 @@
  * @param mixed      ...$params        Optional additional parameters to pass to the callback function when it's called.
  */
-function wp_register_widget_control( $id, $name, $control_callback, $options = array() ) {
+function wp_register_widget_control( $id, $name, $control_callback, $options = array(), ...$params ) {
     global $wp_registered_widget_controls, $wp_registered_widget_updates, $wp_registered_widgets, $_wp_deprecated_widgets_callbacks;
 
@@ -513 +511 @@
         'id'       => $id,
         'callback' => $control_callback,
-        'params'   => array_slice( func_get_args(), 4 ),
+        'params'   => $params,
     );
     $widget = array_merge( $widget, $options );
@@ -544 +542 @@
  * @param mixed    ...$params       Optional additional parameters to pass to the callback function when it's called.
  */
-function _register_widget_update_callback( $id_base, $update_callback, $options = array() ) {
+function _register_widget_update_callback( $id_base, $update_callback, $options = array(), ...$params ) {
     global $wp_registered_widget_updates;
 
@@ -556 +554 @@
     $widget = array(
         'callback' => $update_callback,
-        'params'   => array_slice( func_get_args(), 3 ),
+        'params'   => $params,
     );
 
@@ -578 +576 @@
  */
 
-function _register_widget_form_callback( $id, $name, $form_callback, $options = array() ) {
+function _register_widget_form_callback( $id, $name, $form_callback, $options = array(), ...$params ) {
     global $wp_registered_widget_controls;
 
@@ -604 +602 @@
         'id'       => $id,
         'callback' => $form_callback,
-        'params'   => array_slice( func_get_args(), 4 ),
+        'params'   => $params,
     );
     $widget = array_merge( $widget, $options );