Changeset 45639 for trunk/src/wp-includes/rest-api/class-wp-rest-request.php

Timestamp:

07/15/2019 06:24:08 AM (6 years ago)

Author:

pento

Message:

Code Modernisation: Fix known instances of array access on data types that can't be accessed as arrays.

PHP 7.4 addes a warning when trying access a null/bool/int/float/resource (everything but array, string and object) as if it were an array.

This change fixes all of these warnings visible in unit tests.

Props jrf.
See #47704.

File:

• trunk/src/wp-includes/rest-api/class-wp-rest-request.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/class-wp-rest-request.php

@@ -295 +295 @@
      * @since 4.4.0
      *
-     * @return array Map containing 'value' and 'parameters' keys.
+     * @return array|null Map containing 'value' and 'parameters' keys
+     *                    or null when no valid content-type header was
+     *                    available.
      */
     public function get_content_type() {
@@ -335 +337 @@
 
         $content_type = $this->get_content_type();
-        if ( $content_type['value'] === 'application/json' ) {
+        if ( isset( $content_type['value'] ) && 'application/json' === $content_type['value'] ) {
             $order[] = 'JSON';
         }