Changeset 45639 for trunk/src/wp-includes/wp-db.php

Timestamp:

07/15/2019 06:24:08 AM (6 years ago)

Author:

pento

Message:

Code Modernisation: Fix known instances of array access on data types that can't be accessed as arrays.

PHP 7.4 addes a warning when trying access a null/bool/int/float/resource (everything but array, string and object) as if it were an array.

This change fixes all of these warnings visible in unit tests.

Props jrf.
See #47704.

File:

• trunk/src/wp-includes/wp-db.php (modified) (1 diff)

trunk/src/wp-includes/wp-db.php

@@ -3114 +3114 @@
                 if ( ! empty( $value['db'] ) ) {
                     // We're going to need to truncate by characters or bytes, depending on the length value we have.
-                    if ( 'byte' === $value['length']['type'] ) {
+                    if ( isset( $value['length']['type'] ) && 'byte' === $value['length']['type'] ) {
                         // Using binary causes LEFT() to truncate by bytes.
                         $charset = 'binary';