Changeset 45665 for trunk/phpcs.xml.dist

Timestamp:

07/19/2019 07:47:16 AM (5 months ago)

Author:

pento

Message:

Coding Standards: Move the remaining PHPCS errors to report as warnings, and add Travis tests.

The remaining error-level coding standards issues (specifically, associated with the sniffs WordPress.PHP.YodaConditions.NotYoda, WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase, WordPress.DB.PreparedSQL.InterpolatedNotPrepared, WordPress.DB.PreparedSQL.NotPrepared, and WordPress.Files.FileName.InvalidClassFileName) are marked as warnings, until they're all addressed.

This change allows us to run linting on Travis across the entire codebase, ensuring no other error-level violations can be introduced.

Additionally, PHPCS will now cache results locally, drastically improving performance for subsequent checks: scanning the entire codebase takes 1-2 minutes the first time, and less than one second for subsequent checks.

See #47632.

File:

• trunk/phpcs.xml.dist (modified) (1 diff)

trunk/phpcs.xml.dist

@@ -5 +5 @@
     <rule ref="WordPress-Core"/>
     <rule ref="WordPress.CodeAnalysis.EmptyStatement"/>
+
+    <!-- These rules are being set as warnings instead of errors, so we can error check the entire codebase. -->
+    <rule ref="WordPress.PHP.YodaConditions.NotYoda">
+        <type>warning</type>
+    </rule>
+    <rule ref="WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase">
+        <type>warning</type>
+    </rule>
+    <rule ref="WordPress.DB.PreparedSQL.InterpolatedNotPrepared">
+        <type>warning</type>
+    </rule>
+    <rule ref="WordPress.DB.PreparedSQL.NotPrepared">
+        <type>warning</type>
+    </rule>
+    <rule ref="WordPress.Files.FileName.InvalidClassFileName">
+        <type>warning</type>
+    </rule>
 
     <rule ref="WordPress.NamingConventions.ValidVariableName">