Changeset 45667 for trunk/src/wp-admin/includes/media.php

Timestamp:

07/25/2019 12:47:53 AM (7 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Rename $r variable used with wp_parse_args() to $parsed_args for clarity.

Props freewebmentor.
Fixes #45059.

File:

• trunk/src/wp-admin/includes/media.php (modified) (6 diffs)

trunk/src/wp-admin/includes/media.php

@@ -1494 +1494 @@
                 'show_title' => true,
         );
-        $args         = wp_parse_args( $args, $default_args );
+
+        $parsed_args = wp_parse_args( $args, $default_args );
 
         /**
@@ -1503 +1504 @@
          * @see get_media_item
          *
-         * @param array $args An array of arguments.
+         * @param array $parsed_args An array of arguments.
          */
-        $r = apply_filters( 'get_media_item_args', $args );
+        $parsed_args = apply_filters( 'get_media_item_args', $parsed_args );
 
         $toggle_on  = __( 'Show' );
@@ -1519 +1520 @@
         $type_html       = "<input type='hidden' id='type-of-$attachment_id' value='" . esc_attr( $type ) . "' />";
 
-        $form_fields = get_attachment_fields_to_edit( $post, $r['errors'] );
-
-        if ( $r['toggle'] ) {
-                $class        = empty( $r['errors'] ) ? 'startclosed' : 'startopen';
+        $form_fields = get_attachment_fields_to_edit( $post, $parsed_args['errors'] );
+
+        if ( $parsed_args['toggle'] ) {
+                $class        = empty( $parsed_args['errors'] ) ? 'startclosed' : 'startopen';
                 $toggle_links = "
         <a class='toggle describe-toggle-on' href='#'>$toggle_on</a>
@@ -1532 +1533 @@
 
         $display_title = ( ! empty( $title ) ) ? $title : $filename; // $title shouldn't ever be empty, but just in case
-        $display_title = $r['show_title'] ? "<div class='filename new'><span class='title'>" . wp_html_excerpt( $display_title, 60, '&hellip;' ) . '</span></div>' : '';
+        $display_title = $parsed_args['show_title'] ? "<div class='filename new'><span class='title'>" . wp_html_excerpt( $display_title, 60, '&hellip;' ) . '</span></div>' : '';
 
         $gallery = ( ( isset( $_REQUEST['tab'] ) && 'gallery' == $_REQUEST['tab'] ) || ( isset( $redir_tab ) && 'gallery' == $redir_tab ) );
@@ -1610 +1611 @@
         );
 
-        if ( $r['send'] ) {
-                $r['send'] = get_submit_button( __( 'Insert into Post' ), '', "send[$attachment_id]", false );
-        }
-
-        $delete = empty( $r['delete'] ) ? '' : $r['delete'];
+        if ( $parsed_args['send'] ) {
+                $parsed_args['send'] = get_submit_button( __( 'Insert into Post' ), '', "send[$attachment_id]", false );
+        }
+
+        $delete = empty( $parsed_args['delete'] ) ? '' : $parsed_args['delete'];
         if ( $delete && current_user_can( 'delete_post', $attachment_id ) ) {
                 if ( ! EMPTY_TRASH_DAYS ) {
@@ -1651 +1652 @@
         }
 
-        if ( ( $r['send'] || $thumbnail || $delete ) && ! isset( $form_fields['buttons'] ) ) {
-                $form_fields['buttons'] = array( 'tr' => "\t\t<tr class='submit'><td></td><td class='savesend'>" . $r['send'] . " $thumbnail $delete</td></tr>\n" );
+        if ( ( $parsed_args['send'] || $thumbnail || $delete ) && ! isset( $form_fields['buttons'] ) ) {
+                $form_fields['buttons'] = array( 'tr' => "\t\t<tr class='submit'><td></td><td class='savesend'>" . $parsed_args['send'] . " $thumbnail $delete</td></tr>\n" );
         }
         $hidden_fields = array();