Changeset 45667 for trunk/src/wp-admin/includes/template.php

Timestamp:

07/25/2019 12:47:53 AM (7 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Rename $r variable used with wp_parse_args() to $parsed_args for clarity.

Props freewebmentor.
Fixes #45059.

File:

• trunk/src/wp-admin/includes/template.php (modified) (9 diffs)

trunk/src/wp-admin/includes/template.php

@@ -101 +101 @@
         $params = apply_filters( 'wp_terms_checklist_args', $args, $post_id );
 
-        $r = wp_parse_args( $params, $defaults );
-
-        if ( empty( $r['walker'] ) || ! ( $r['walker'] instanceof Walker ) ) {
+        $parsed_args = wp_parse_args( $params, $defaults );
+
+        if ( empty( $parsed_args['walker'] ) || ! ( $parsed_args['walker'] instanceof Walker ) ) {
                 $walker = new Walker_Category_Checklist;
         } else {
-                $walker = $r['walker'];
-        }
-
-        $taxonomy             = $r['taxonomy'];
-        $descendants_and_self = (int) $r['descendants_and_self'];
+                $walker = $parsed_args['walker'];
+        }
+
+        $taxonomy             = $parsed_args['taxonomy'];
+        $descendants_and_self = (int) $parsed_args['descendants_and_self'];
 
         $args = array( 'taxonomy' => $taxonomy );
@@ -117 +117 @@
         $args['disabled'] = ! current_user_can( $tax->cap->assign_terms );
 
-        $args['list_only'] = ! empty( $r['list_only'] );
-
-        if ( is_array( $r['selected_cats'] ) ) {
-                $args['selected_cats'] = $r['selected_cats'];
+        $args['list_only'] = ! empty( $parsed_args['list_only'] );
+
+        if ( is_array( $parsed_args['selected_cats'] ) ) {
+                $args['selected_cats'] = $parsed_args['selected_cats'];
         } elseif ( $post_id ) {
                 $args['selected_cats'] = wp_get_object_terms( $post_id, $taxonomy, array_merge( $args, array( 'fields' => 'ids' ) ) );
@@ -126 +126 @@
                 $args['selected_cats'] = array();
         }
-        if ( is_array( $r['popular_cats'] ) ) {
-                $args['popular_cats'] = $r['popular_cats'];
+        if ( is_array( $parsed_args['popular_cats'] ) ) {
+                $args['popular_cats'] = $parsed_args['popular_cats'];
         } else {
                 $args['popular_cats'] = get_terms(
@@ -157 +157 @@
         $output = '';
 
-        if ( $r['checked_ontop'] ) {
+        if ( $parsed_args['checked_ontop'] ) {
                 // Post process $categories rather than adding an exclude to the get_terms() query to keep the query the same across all posts (for any query cache)
                 $checked_categories = array();
@@ -175 +175 @@
         $output .= call_user_func_array( array( $walker, 'walk' ), array( $categories, 0, $args ) );
 
-        if ( $r['echo'] ) {
+        if ( $parsed_args['echo'] ) {
                 echo $output;
         }
@@ -2442 +2442 @@
  */
 function wp_star_rating( $args = array() ) {
-        $defaults = array(
+        $defaults    = array(
                 'rating' => 0,
                 'type'   => 'rating',
@@ -2448 +2448 @@
                 'echo'   => true,
         );
-        $r        = wp_parse_args( $args, $defaults );
+        $parsed_args = wp_parse_args( $args, $defaults );
 
         // Non-English decimal places when the $rating is coming from a string
-        $rating = (float) str_replace( ',', '.', $r['rating'] );
+        $rating = (float) str_replace( ',', '.', $parsed_args['rating'] );
 
         // Convert Percentage to star rating, 0..5 in .5 increments
-        if ( 'percent' === $r['type'] ) {
+        if ( 'percent' === $parsed_args['type'] ) {
                 $rating = round( $rating / 10, 0 ) / 2;
         }
@@ -2463 +2463 @@
         $empty_stars = 5 - $full_stars - $half_stars;
 
-        if ( $r['number'] ) {
+        if ( $parsed_args['number'] ) {
                 /* translators: 1: the rating, 2: the number of ratings */
-                $format = _n( '%1$s rating based on %2$s rating', '%1$s rating based on %2$s ratings', $r['number'] );
-                $title  = sprintf( $format, number_format_i18n( $rating, 1 ), number_format_i18n( $r['number'] ) );
+                $format = _n( '%1$s rating based on %2$s rating', '%1$s rating based on %2$s ratings', $parsed_args['number'] );
+                $title  = sprintf( $format, number_format_i18n( $rating, 1 ), number_format_i18n( $parsed_args['number'] ) );
         } else {
                 /* translators: %s: the rating */
@@ -2479 +2479 @@
         $output .= '</div>';
 
-        if ( $r['echo'] ) {
+        if ( $parsed_args['echo'] ) {
                 echo $output;
         }