Changeset 45683

Timestamp:

07/26/2019 05:45:21 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Accessibility: Taxonomy: When a new category or tag is being added, show a spinner and noop the button to avoid multiple requests.

Props andg, afercia, guddu1315, SergeyBiryukov.
Fixes #47607.

Location:

trunk/src

Files:

• js/_enqueues/admin/tags.js (modified) (3 diffs)
• wp-admin/css/edit.css (modified) (1 diff)
• wp-admin/edit-tags.php (modified) (1 diff)

trunk/src/js/_enqueues/admin/tags.js

@@ -11 +11 @@
 
 jQuery(document).ready(function($) {
+
+    var addingTerm = false;
 
     /**
@@ -103 +105 @@
             return false;
 
+        if ( addingTerm ) {
+            // If we're adding a term, noop the button to avoid duplicate requests.
+            return false;
+        }
+
+        addingTerm = true;
+        form.find( '.submit .spinner' ).addClass( 'is-active' );
+
         /**
          * Does a request to the server to add a new term to the database
@@ -112 +122 @@
         $.post(ajaxurl, $('#addtag').serialize(), function(r){
             var res, parent, term, indent, i;
+
+            addingTerm = false;
+            form.find( '.submit .spinner' ).removeClass( 'is-active' );
 
             $('#ajax-response').empty();

trunk/src/wp-admin/css/edit.css

@@ -1162 +1162 @@
 .ac_match {
     text-decoration: underline;
+}
+
+#addtag .spinner {
+    float: none;
+    vertical-align: top;
 }
 

trunk/src/wp-admin/edit-tags.php

@@ -516 +516 @@
      */
     do_action( "{$taxonomy}_add_form_fields", $taxonomy );
-
-    submit_button( $tax->labels->add_new_item );
-
+    ?>
+    <p class="submit">
+        <?php submit_button( $tax->labels->add_new_item, 'primary', 'submit', false ); ?>
+        <span class="spinner"></span>
+    </p>
+    <?php
     if ( 'category' == $taxonomy ) {
         /**