Changeset 45705 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

Timestamp:

07/31/2019 07:59:30 PM (5 years ago)

Author:

kadamwhite

Message:

REST API: Generate sample permalink only when a dependent field is requested.

The sample permalink will now only be generated if the derivative permalink_template or generated_slug fields are to be included in the response, preventing an unnecessary database request for each post (via wp_unique_post_slug()) when those fields are not requested.

Props dlh.
See #45605.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -1614 +1614 @@
         $post_type_obj = get_post_type_object( $post->post_type );
         if ( is_post_type_viewable( $post_type_obj ) && $post_type_obj->public ) {
-
-            if ( ! function_exists( 'get_sample_permalink' ) ) {
-                require_once ABSPATH . 'wp-admin/includes/post.php';
-            }
-
-            $sample_permalink = get_sample_permalink( $post->ID, $post->post_title, '' );
-
-            if ( in_array( 'permalink_template', $fields, true ) ) {
-                $data['permalink_template'] = $sample_permalink[0];
-            }
-            if ( in_array( 'generated_slug', $fields, true ) ) {
-                $data['generated_slug'] = $sample_permalink[1];
+            $permalink_template_requested = in_array( 'permalink_template', $fields, true );
+            $generated_slug_requested     = in_array( 'generated_slug', $fields, true );
+
+            if ( $permalink_template_requested || $generated_slug_requested ) {
+                if ( ! function_exists( 'get_sample_permalink' ) ) {
+                    require_once ABSPATH . 'wp-admin/includes/post.php';
+                }
+
+                $sample_permalink = get_sample_permalink( $post->ID, $post->post_title, '' );
+
+                if ( $permalink_template_requested ) {
+                    $data['permalink_template'] = $sample_permalink[0];
+                }
+
+                if ( $generated_slug_requested ) {
+                    $data['generated_slug'] = $sample_permalink[1];
+                }
             }
         }