Changeset 45706 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php

Timestamp:

07/31/2019 08:20:02 PM (6 years ago)

Author:

kadamwhite

Message:

REST API: Skip processing fields which are not present in the selected context.

In WP_REST_Controller::get_fields_for_response(), exclude fields which are not registered to appear in the request's context.

In conjunction with r45705 this prevents the unnecessary computation of the sample permalink when making a request that is not context=edit.

Props dlh.
Fixes #45605.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php

@@ -518 +518 @@
      */
     public function get_fields_for_response( $request ) {
-        $schema = $this->get_item_schema();
-        $fields = isset( $schema['properties'] ) ? array_keys( $schema['properties'] ) : array();
+        $schema     = $this->get_item_schema();
+        $properties = isset( $schema['properties'] ) ? $schema['properties'] : array();
 
         $additional_fields = $this->get_additional_fields();
@@ -526 +526 @@
             // because it won't be present in $this->get_item_schema().
             if ( is_null( $field_options['schema'] ) ) {
-                $fields[] = $field_name;
-            }
-        }
+                $properties[ $field_name ] = $field_options;
+            }
+        }
+
+        // Exclude fields that specify a different context than the request context.
+        $context = $request['context'];
+        if ( $context ) {
+            foreach ( $properties as $name => $options ) {
+                if ( ! empty( $options['context'] ) && ! in_array( $context, $options['context'], true ) ) {
+                    unset( $properties[ $name ] );
+                }
+            }
+        }
+
+        $fields = array_keys( $properties );
 
         if ( ! isset( $request['_fields'] ) ) {