Changeset 45754

Timestamp:

08/05/2019 01:54:43 PM (7 years ago)

Author:

SergeyBiryukov

Message:

General: Correctly detect large floats in is_serialized().

Props killerbishop, donmhico, hoythan.
Fixes #46570.

Location:

trunk

Files:

• src/wp-includes/functions.php (modified) (1 diff)
• tests/phpunit/tests/functions.php (modified) (1 diff)

trunk/src/wp-includes/functions.php

@@ -529 +529 @@
                 case 'd':
                         $end = $strict ? '$' : '';
-                        return (bool) preg_match( "/^{$token}:[0-9.E-]+;$end/", $data );
+                        return (bool) preg_match( "/^{$token}:[0-9.E+-]+;$end/", $data );
         }
         return false;

trunk/tests/phpunit/tests/functions.php

@@ -227 +227 @@
                 foreach ( $not_serialized as $case ) {
                         $this->assertFalse( is_serialized( $case ), "Test data: $case" );
+                }
+        }
+
+        /**
+         * @ticket 46570
+         */
+        function test_is_serialized_should_return_true_for_large_floats() {
+                $cases = array(
+                        serialize( 1.7976931348623157E+308 ),
+                        serialize( array( 1.7976931348623157E+308, 1.23e50 ) )
+                );
+
+                foreach ( $cases as $case ) {
+                        $this->assertTrue( is_serialized( $case ), "Serialized data: $case" );
                 }
         }