Changeset 45787

Timestamp:

08/13/2019 05:08:14 AM (5 years ago)

Author:

peterwilsoncc

Message:

Comments: Include post permalink in comment reply link.

Include the post's permalink when generating reply links in get_comment_reply_link() to account for comments displayed on index and archive pages.

This reapplies [32786] which was inadvertently reverted in [42360].

Props justinahinon, donmhico.
See #33383.
Fixes #47174.

Location:

trunk

Files:

• src/wp-includes/comment-template.php (modified) (1 diff)
• tests/phpunit/tests/comment/getCommentReplyLink.php (modified) (1 diff)

trunk/src/wp-includes/comment-template.php

@@ -1698 +1698 @@
                         'unapproved'      => false,
                         'moderation-hash' => false,
-                    )
+                    ),
+                    get_permalink( $post->ID )
                 )
             ) . '#' . $args['respond_id'],

trunk/tests/phpunit/tests/comment/getCommentReplyLink.php

@@ -27 +27 @@
         $this->assertNull( get_comment_reply_link( $args ) );
     }
+
+    /**
+     * Ensure comment reply links include post permalink.
+     *
+     * @ticket 47174
+     */
+    public function test_get_comment_reply_link_should_include_post_permalink() {
+        // Create a sample post.
+        $post_id = self::factory()->post->create();
+
+        // Insert comment.
+        $comment_id = self::factory()->comment->create(
+            array(
+                'comment_post_ID' => $post_id,
+                'user_id'         => 1,
+            )
+        );
+
+        // `depth` and `max_depth` required for reply links to display.
+        $comment_reply_link = get_comment_reply_link(
+            array(
+                'depth'     => 1,
+                'max_depth' => 5,
+            ),
+            $comment_id,
+            $post_id
+        );
+
+        $expected_url = esc_url(
+            add_query_arg(
+                array(
+                    'p'          => $post_id,
+                    'replytocom' => $comment_id,
+                ),
+                home_url( '/#respond' )
+            )
+        );
+
+        $this->assertContains( $expected_url, $comment_reply_link );
+    }
 }