Changeset 45809 for trunk/src/wp-includes/rest-api/class-wp-rest-server.php

Timestamp:

08/15/2019 07:55:13 PM (21 months ago)

Author:

kadamwhite

Message:

REST API: Do not send response body if status is 204 or body is null.

Status code 204 should indicate no response body is sent. Previously, a "null" string was sent, which MacOS Safari would try to parse as JSON and thereby fail to complete the request.

Props TimothyBlynJacobs, andizer, matthias.thiel.
Fixes #43691.

File:

• trunk/src/wp-includes/rest-api/class-wp-rest-server.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/class-wp-rest-server.php

@@ -405 +405 @@
              */
             $result = apply_filters( 'rest_pre_echo_response', $result, $this, $request );
+
+            // The 204 response shouldn't have a body.
+            if ( 204 === $code || null === $result ) {
+                return null;
+            }
 
             $result = wp_json_encode( $result );