WordPress.org

Make WordPress Core


Ignore:
Timestamp:
08/15/2019 09:08:05 PM (2 months ago)
Author:
kadamwhite
Message:

REST API: Cache results of get_item_schema on controller instances for performance.

Caches the output of get_item_schema() to avoid redundant recomputation of translatable strings and other computed values. This method is called many times per item in each REST request, and the results of the method should not vary between calls.
Additional schema fields are not cached.

Props kadamwhite, joehoyle, TimothyBlynJacobs.
Fixes #47871.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php

    r44934 r45811  
    418418     */
    419419    public function get_item_schema() {
     420        if ( $this->schema ) {
     421            return $this->add_additional_fields_schema( $this->schema );
     422        }
    420423
    421424        $schema = parent::get_item_schema();
     
    514517        unset( $schema['properties']['password'] );
    515518
    516         return $schema;
     519        $this->schema = $schema;
     520        return $this->add_additional_fields_schema( $this->schema );
    517521    }
    518522
Note: See TracChangeset for help on using the changeset viewer.