Changeset 45811 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

Timestamp:

08/15/2019 09:08:05 PM (6 years ago)

Author:

kadamwhite

Message:

REST API: Cache results of get_item_schema on controller instances for performance.

Caches the output of get_item_schema() to avoid redundant recomputation of translatable strings and other computed values. This method is called many times per item in each REST request, and the results of the method should not vary between calls.
Additional schema fields are not cached.

Props kadamwhite, joehoyle, TimothyBlynJacobs.
Fixes #47871.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

@@ -1216 +1216 @@
      */
     public function get_item_schema() {
+        if ( $this->schema ) {
+            return $this->add_additional_fields_schema( $this->schema );
+        }
+
         $schema = array(
             '$schema'    => 'http://json-schema.org/draft-04/schema#',
@@ -1365 +1369 @@
         $schema['properties']['meta'] = $this->meta->get_field_schema();
 
-        return $this->add_additional_fields_schema( $schema );
+        $this->schema = $schema;
+        return $this->add_additional_fields_schema( $this->schema );
     }