WordPress.org

Make WordPress Core


Ignore:
Timestamp:
08/15/2019 09:08:05 PM (2 months ago)
Author:
kadamwhite
Message:

REST API: Cache results of get_item_schema on controller instances for performance.

Caches the output of get_item_schema() to avoid redundant recomputation of translatable strings and other computed values. This method is called many times per item in each REST request, and the results of the method should not vary between calls.
Additional schema fields are not cached.

Props kadamwhite, joehoyle, TimothyBlynJacobs.
Fixes #47871.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

    r45705 r45811  
    18711871     */
    18721872    public function get_item_schema() {
     1873        if ( $this->schema ) {
     1874            return $this->add_additional_fields_schema( $this->schema );
     1875        }
    18731876
    18741877        $schema = array(
     
    22302233        }
    22312234
    2232         return $this->add_additional_fields_schema( $schema );
     2235        $this->schema = $schema;
     2236        return $this->add_additional_fields_schema( $this->schema );
    22332237    }
    22342238
Note: See TracChangeset for help on using the changeset viewer.