WordPress.org

Make WordPress Core


Ignore:
Timestamp:
08/15/2019 09:08:05 PM (2 months ago)
Author:
kadamwhite
Message:

REST API: Cache results of get_item_schema on controller instances for performance.

Caches the output of get_item_schema() to avoid redundant recomputation of translatable strings and other computed values. This method is called many times per item in each REST request, and the results of the method should not vary between calls.
Additional schema fields are not cached.

Props kadamwhite, joehoyle, TimothyBlynJacobs.
Fixes #47871.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-settings-controller.php

    r43571 r45811  
    271271     */
    272272    public function get_item_schema() {
     273        if ( $this->schema ) {
     274            return $this->add_additional_fields_schema( $this->schema );
     275        }
     276
    273277        $options = $this->get_registered_options();
    274278
     
    287291        }
    288292
    289         return $this->add_additional_fields_schema( $schema );
     293        $this->schema = $schema;
     294        return $this->add_additional_fields_schema( $this->schema );
    290295    }
    291296
Note: See TracChangeset for help on using the changeset viewer.