Make WordPress Core


Ignore:
Timestamp:
08/15/2019 09:08:05 PM (5 years ago)
Author:
kadamwhite
Message:

REST API: Cache results of get_item_schema on controller instances for performance.

Caches the output of get_item_schema() to avoid redundant recomputation of translatable strings and other computed values. This method is called many times per item in each REST request, and the results of the method should not vary between calls.
Additional schema fields are not cached.

Props kadamwhite, joehoyle, TimothyBlynJacobs.
Fixes #47871.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-taxonomies-controller.php

    r43571 r45811  
    277277     */
    278278    public function get_item_schema() {
     279        if ( $this->schema ) {
     280            return $this->add_additional_fields_schema( $this->schema );
     281        }
     282
    279283        $schema = array(
    280284            '$schema'    => 'http://json-schema.org/draft-04/schema#',
     
    374378            ),
    375379        );
    376         return $this->add_additional_fields_schema( $schema );
     380
     381        $this->schema = $schema;
     382        return $this->add_additional_fields_schema( $this->schema );
    377383    }
    378384
Note: See TracChangeset for help on using the changeset viewer.