Make WordPress Core


Ignore:
Timestamp:
08/15/2019 09:08:05 PM (5 years ago)
Author:
kadamwhite
Message:

REST API: Cache results of get_item_schema on controller instances for performance.

Caches the output of get_item_schema() to avoid redundant recomputation of translatable strings and other computed values. This method is called many times per item in each REST request, and the results of the method should not vary between calls.
Additional schema fields are not cached.

Props kadamwhite, joehoyle, TimothyBlynJacobs.
Fixes #47871.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php

    r45723 r45811  
    857857     */
    858858    public function get_item_schema() {
     859        if ( $this->schema ) {
     860            return $this->add_additional_fields_schema( $this->schema );
     861        }
     862
    859863        $schema = array(
    860864            '$schema'    => 'http://json-schema.org/draft-04/schema#',
     
    925929        $schema['properties']['meta'] = $this->meta->get_field_schema();
    926930
    927         return $this->add_additional_fields_schema( $schema );
     931        $this->schema = $schema;
     932        return $this->add_additional_fields_schema( $this->schema );
    928933    }
    929934
Note: See TracChangeset for help on using the changeset viewer.