WordPress.org

Make WordPress Core


Ignore:
Timestamp:
08/15/2019 09:08:05 PM (2 months ago)
Author:
kadamwhite
Message:

REST API: Cache results of get_item_schema on controller instances for performance.

Caches the output of get_item_schema() to avoid redundant recomputation of translatable strings and other computed values. This method is called many times per item in each REST request, and the results of the method should not vary between calls.
Additional schema fields are not cached.

Props kadamwhite, joehoyle, TimothyBlynJacobs.
Fixes #47871.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-themes-controller.php

    r44138 r45811  
    148148     */
    149149    public function get_item_schema() {
     150        if ( $this->schema ) {
     151            return $this->add_additional_fields_schema( $this->schema );
     152        }
     153
    150154        $schema = array(
    151155            '$schema'    => 'http://json-schema.org/draft-04/schema#',
     
    178182        );
    179183
    180         return $this->add_additional_fields_schema( $schema );
     184        $this->schema = $schema;
     185        return $this->add_additional_fields_schema( $this->schema );
    181186    }
    182187
Note: See TracChangeset for help on using the changeset viewer.