Changeset 45813

Timestamp:

08/15/2019 10:11:07 PM (5 years ago)

Author:

kadamwhite

Message:

REST API: Always return post types list in taxonomies endpoint response as an array.

Prevents a non-sequential post type array such as [ 0 => 'post', 2 => 'page' ] from being improperly converted to an object in the taxonomy endpoint's response JSON.

Props TimothyBlynJacobs, birgire, spectacula.
Fixes #42209.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-taxonomies-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-taxonomies-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-taxonomies-controller.php

@@ -211 +211 @@
 
         if ( in_array( 'types', $fields, true ) ) {
-            $data['types'] = $taxonomy->object_type;
+            $data['types'] = array_values( $taxonomy->object_type );
         }
 

trunk/tests/phpunit/tests/rest-api/rest-taxonomies-controller.php

@@ -194 +194 @@
             array_keys( $response->get_data() )
         );
+    }
+
+    public function test_object_types_is_an_array_if_object_type_is_unregistered() {
+        register_taxonomy_for_object_type( 'category', 'page' );
+        register_taxonomy_for_object_type( 'category', 'attachment' );
+        unregister_taxonomy_for_object_type( 'category', 'page' );
+
+        $request  = new WP_REST_Request( 'GET', '/wp/v2/taxonomies/category' );
+        $response = rest_get_server()->dispatch( $request );
+
+        $types = $response->get_data()['types'];
+        $this->assertArrayHasKey( 0, $types );
+        $this->assertEquals( 'post', $types[0] );
+        $this->assertArrayHasKey( 1, $types );
+        $this->assertEquals( 'attachment', $types[1] );
     }