Changeset 45828

Timestamp:

08/19/2019 03:55:47 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Menus: Fix the Custom Links text fallback.

When adding a Custom Link and leaving the "Link Text" field empty, WordPress used to set a default fallback text: "Menu Item".

The changes in [36379] broke this behavior making the fallback text: (Pending), with a leading space.

Pending major refactoring of the Menus page (which is going to use a block-based user interface) this change just restores the original behavior by adding the fallback text to the related AJAX response.

Props christophherr, Fencer04, thakkarhardik, backermann1978, audrasjb.
Merges [45727] to the 5.2 branch.
Fixes #38415.

Location:

branches/5.2

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/ajax-actions.php (modified) (1 diff)

branches/5.2/src/wp-admin/includes/ajax-actions.php

@@ -1424 +1424 @@
         if ( ! empty( $menu_obj->ID ) ) {
             $menu_obj        = wp_setup_nav_menu_item( $menu_obj );
+            $menu_obj->title = empty( $menu_obj->title ) ? __( 'Menu Item' ) : $menu_obj->title;
             $menu_obj->label = $menu_obj->title; // don't show "(pending)" in ajax-added items
             $menu_items[]    = $menu_obj;