Changeset 45832 for branches/5.2/src/wp-includes/nav-menu.php

Timestamp:

08/19/2019 04:06:15 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Menus: Trim whitespace from custom link URLs.

Props majemedia, SergeyBiryukov.
Merges [45655] and [45656] to the 5.2 branch.
Fixes #47723.

Location:

branches/5.2

Files:

• . (modified) (1 prop)
• src/wp-includes/nav-menu.php (modified) (1 diff)

branches/5.2/src/wp-includes/nav-menu.php

@@ -457 +457 @@
     $original_parent = 0 < $menu_item_db_id ? get_post_field( 'post_parent', $menu_item_db_id ) : 0;
 
-    if ( 'custom' != $args['menu-item-type'] ) {
-        /* if non-custom menu item, then:
-            * use original object's URL
-            * blank default title to sync with original object's
-        */
+    if ( 'custom' === $args['menu-item-type'] ) {
+        // If custom menu item, trim the URL.
+        $args['menu-item-url'] = trim( $args['menu-item-url'] );
+    } else {
+        /*
+         * If non-custom menu item, then:
+         * - use the original object's URL.
+         * - blank default title to sync with the original object's title.
+         */
 
         $args['menu-item-url'] = '';