Changeset 45834 for branches/5.2/src/wp-admin/custom-header.php

Timestamp:

08/19/2019 04:12:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Accessibility: Make sure layout tables across the admin are correctly linearized.

Adds role="presentation" to the <table> elements used for layout purposes.

Ideally, HTML tables should be used for tabular data. When tables are used for layout purposes, it's important to remove any native semantics so that assistive technologies can correctly announce the table content in a linearized fashion.

Props greatislander, afercia.
Merges [45403] to the 5.2 branch.
See #46899.

Location:

branches/5.2

Files:

• . (modified) (1 prop)
• src/wp-admin/custom-header.php (modified) (3 diffs)

branches/5.2/src/wp-admin/custom-header.php

@@ -491 +491 @@
 <h3><?php _e( 'Header Image' ); ?></h3>
 
-<table class="form-table">
+<table class="form-table" role="presentation">
 <tbody>
 
@@ -629 +629 @@
 <form method="post" action="<?php echo esc_url( add_query_arg( 'step', 1 ) ); ?>">
         <?php submit_button( null, 'screen-reader-text', 'save-header-options', false ); ?>
-<table class="form-table">
+<table class="form-table" role="presentation">
 <tbody>
         <?php if ( get_uploaded_header_images() ) : ?>
@@ -690 +690 @@
 <h3><?php _e( 'Header Text' ); ?></h3>
 
-<table class="form-table">
+<table class="form-table" role="presentation">
 <tbody>
 <tr>