Changeset 45834 for branches/5.2/src/wp-admin/network/site-users.php

Timestamp:

08/19/2019 04:12:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Accessibility: Make sure layout tables across the admin are correctly linearized.

Adds role="presentation" to the <table> elements used for layout purposes.

Ideally, HTML tables should be used for tabular data. When tables are used for layout purposes, it's important to remove any native semantics so that assistive technologies can correctly announce the table content in a linearized fashion.

Props greatislander, afercia.
Merges [45403] to the 5.2 branch.
See #46899.

Location:

branches/5.2

Files:

• . (modified) (1 prop)
• src/wp-admin/network/site-users.php (modified) (2 diffs)

branches/5.2/src/wp-admin/network/site-users.php

@@ -301 +301 @@
 <form action="site-users.php?action=adduser" id="adduser" method="post">
     <input type="hidden" name="id" value="<?php echo esc_attr( $id ); ?>" />
-    <table class="form-table">
+    <table class="form-table" role="presentation">
         <tr>
             <th scope="row"><label for="newuser"><?php _e( 'Username' ); ?></label></th>
@@ -335 +335 @@
 <form action="<?php echo network_admin_url( 'site-users.php?action=newuser' ); ?>" id="newuser" method="post">
     <input type="hidden" name="id" value="<?php echo esc_attr( $id ); ?>" />
-    <table class="form-table">
+    <table class="form-table" role="presentation">
         <tr>
             <th scope="row"><label for="user_username"><?php _e( 'Username' ); ?></label></th>