Changeset 45834 for branches/5.2/src/wp-admin/options-media.php

Timestamp:

08/19/2019 04:12:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Accessibility: Make sure layout tables across the admin are correctly linearized.

Adds role="presentation" to the <table> elements used for layout purposes.

Ideally, HTML tables should be used for tabular data. When tables are used for layout purposes, it's important to remove any native semantics so that assistive technologies can correctly announce the table content in a linearized fashion.

Props greatislander, afercia.
Merges [45403] to the 5.2 branch.
See #46899.

Location:

branches/5.2

Files:

• . (modified) (1 prop)
• src/wp-admin/options-media.php (modified) (3 diffs)

branches/5.2/src/wp-admin/options-media.php

@@ -52 +52 @@
 <p><?php _e( 'The sizes listed below determine the maximum dimensions in pixels to use when adding an image to the Media Library.' ); ?></p>
 
-<table class="form-table">
+<table class="form-table" role="presentation">
 <tr>
 <th scope="row"><?php _e( 'Thumbnail size' ); ?></th>
@@ -99 +99 @@
     ?>
 <h2 class="title"><?php _e( 'Embeds' ); ?></h2>
-<table class="form-table">
+<table class="form-table" role="presentation">
     <?php do_settings_fields( 'media', 'embeds' ); ?>
 </table>
@@ -106 +106 @@
 <?php if ( ! is_multisite() ) : ?>
 <h2 class="title"><?php _e( 'Uploading Files' ); ?></h2>
-<table class="form-table">
+<table class="form-table" role="presentation">
     <?php
     // If upload_url_path is not the default (empty), and upload_path is not the default ('wp-content/uploads' or empty)