Changeset 45835 for branches/5.2/src/wp-admin/includes/network.php

Timestamp:

08/19/2019 04:14:38 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Accessibility: Improve settings tables and forms after [45403].

• adds role="presentation" to the edit comment table
• removes a few pointless <fieldset> elements
• adds a few missing <label> elements
• adds the CSS class class="td-full" to table rows spanning to multiple cells
• adds explicit scope="row" attribute to the table headers in options-permalink.php: this table is better communicated as data table
• uses consistent label association in the "Privacy Settings" page
• in the installation page "Set up your database connection": associates descriptions to their inout fields using aria-describedby
• improves the link to gravatar.com in the user-edit.php page

Props afercia.
Merges [45416] to the 5.2 branch.
See #46899.
Fixes #47390.

Location:

branches/5.2

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/network.php (modified) (2 diffs)

branches/5.2/src/wp-admin/includes/network.php

@@ -348 +348 @@
         <?php endif; ?>
             <tr>
-                <th scope='row'><?php esc_html_e( 'Network Title' ); ?></th>
-                <td>
-                    <input name='sitename' type='text' size='45' value='<?php echo esc_attr( $site_name ); ?>' />
+                <th scope='row'><label for="sitename"><?php esc_html_e( 'Network Title' ); ?></label></th>
+                <td>
+                    <input name='sitename' id='sitename' type='text' size='45' value='<?php echo esc_attr( $site_name ); ?>' />
                     <p class="description">
                         <?php _e( 'What would you like to call your network?' ); ?>
@@ -357 +357 @@
             </tr>
             <tr>
-                <th scope='row'><?php esc_html_e( 'Network Admin Email' ); ?></th>
-                <td>
-                    <input name='email' type='text' size='45' value='<?php echo esc_attr( $admin_email ); ?>' />
+                <th scope='row'><label for="email"><?php esc_html_e( 'Network Admin Email' ); ?></label></th>
+                <td>
+                    <input name='email' id='email' type='text' size='45' value='<?php echo esc_attr( $admin_email ); ?>' />
                     <p class="description">
                         <?php _e( 'Your email address.' ); ?>