Changeset 45835 for branches/5.2/src/wp-admin/options-discussion.php

Timestamp:

08/19/2019 04:14:38 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Accessibility: Improve settings tables and forms after [45403].

• adds role="presentation" to the edit comment table
• removes a few pointless <fieldset> elements
• adds a few missing <label> elements
• adds the CSS class class="td-full" to table rows spanning to multiple cells
• adds explicit scope="row" attribute to the table headers in options-permalink.php: this table is better communicated as data table
• uses consistent label association in the "Privacy Settings" page
• in the installation page "Set up your database connection": associates descriptions to their inout fields using aria-describedby
• improves the link to gravatar.com in the user-edit.php page

Props afercia.
Merges [45416] to the 5.2 branch.
See #46899.
Fixes #47390.

Location:

branches/5.2

Files:

• . (modified) (1 prop)
• src/wp-admin/options-discussion.php (modified) (2 diffs)

branches/5.2/src/wp-admin/options-discussion.php

@@ -222 +222 @@
 <tr>
 <th scope="row"><?php _e( 'Avatar Display' ); ?></th>
-<td><fieldset><legend class="screen-reader-text"><span><?php _e( 'Avatar Display' ); ?></span></legend>
+<td>
     <label for="show_avatars">
         <input type="checkbox" id="show_avatars" name="show_avatars" value="1" <?php checked( $show_avatars, 1 ); ?> />
         <?php _e( 'Show Avatars' ); ?>
     </label>
-</fieldset></td>
+</td>
 </tr>
 <tr class="avatar-settings<?php echo $show_avatars_class; ?>">
@@ -256 +256 @@
 <td class="defaultavatarpicker"><fieldset><legend class="screen-reader-text"><span><?php _e( 'Default Avatar' ); ?></span></legend>
 
+<p>
 <?php _e( 'For users without a custom avatar of their own, you can either display a generic logo or a generated one based on their email address.' ); ?><br />
+</p>
 
 <?php