WordPress.org

Make WordPress Core


Ignore:
Timestamp:
08/19/2019 04:14:38 AM (2 years ago)
Author:
SergeyBiryukov
Message:

Accessibility: Improve settings tables and forms after [45403].

  • adds role="presentation" to the edit comment table
  • removes a few pointless <fieldset> elements
  • adds a few missing <label> elements
  • adds the CSS class class="td-full" to table rows spanning to multiple cells
  • adds explicit scope="row" attribute to the table headers in options-permalink.php: this table is better communicated as data table
  • uses consistent label association in the "Privacy Settings" page
  • in the installation page "Set up your database connection": associates descriptions to their inout fields using aria-describedby
  • improves the link to gravatar.com in the user-edit.php page

Props afercia.
Merges [45416] to the 5.2 branch.
See #46899.
Fixes #47390.

Location:
branches/5.2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • branches/5.2

  • branches/5.2/src/wp-admin/options-discussion.php

    r45834 r45835  
    222222<tr>
    223223<th scope="row"><?php _e( 'Avatar Display' ); ?></th>
    224 <td><fieldset><legend class="screen-reader-text"><span><?php _e( 'Avatar Display' ); ?></span></legend>
     224<td>
    225225    <label for="show_avatars">
    226226        <input type="checkbox" id="show_avatars" name="show_avatars" value="1" <?php checked( $show_avatars, 1 ); ?> />
    227227        <?php _e( 'Show Avatars' ); ?>
    228228    </label>
    229 </fieldset></td>
     229</td>
    230230</tr>
    231231<tr class="avatar-settings<?php echo $show_avatars_class; ?>">
     
    256256<td class="defaultavatarpicker"><fieldset><legend class="screen-reader-text"><span><?php _e( 'Default Avatar' ); ?></span></legend>
    257257
     258<p>
    258259<?php _e( 'For users without a custom avatar of their own, you can either display a generic logo or a generated one based on their email address.' ); ?><br />
     260</p>
    259261
    260262<?php
Note: See TracChangeset for help on using the changeset viewer.