Changeset 45835 for branches/5.2/src/wp-admin/privacy.php

Timestamp:

08/19/2019 04:14:38 AM (7 years ago)

Author:

SergeyBiryukov

Message:

Accessibility: Improve settings tables and forms after [45403].

• adds role="presentation" to the edit comment table
• removes a few pointless <fieldset> elements
• adds a few missing <label> elements
• adds the CSS class class="td-full" to table rows spanning to multiple cells
• adds explicit scope="row" attribute to the table headers in options-permalink.php: this table is better communicated as data table
• uses consistent label association in the "Privacy Settings" page
• in the installation page "Set up your database connection": associates descriptions to their inout fields using aria-describedby
• improves the link to gravatar.com in the user-edit.php page

Props afercia.
Merges [45416] to the 5.2 branch.
See #46899.
Fixes #47390.

Location:

branches/5.2

Files:

• . (modified) (1 prop)
• src/wp-admin/privacy.php (modified) (3 diffs)

branches/5.2/src/wp-admin/privacy.php

@@ -192 +192 @@
 
         <hr>
-        <table class="form-table tools-privacy-policy-page">
+        <table class="form-table tools-privacy-policy-page" role="presentation">
                 <tr>
-                        <th scope="row">
+                        <th scope="row"><label for="page_for_privacy_policy">
                                 <?php
                                 if ( $privacy_policy_page_exists ) {
@@ -202 +202 @@
                                 }
                                 ?>
-                        </th>
+                        </label></th>
                         <td>
                                 <?php
@@ -219 +219 @@
                                         ?>
                                         <form method="post" action="">
-                                                <label for="page_for_privacy_policy">
-                                                        <?php _e( 'Select an existing page:' ); ?>
-                                                </label>
                                                 <input type="hidden" name="action" value="set-privacy-page" />
                                                 <?php