WordPress.org

Make WordPress Core


Ignore:
Timestamp:
08/19/2019 04:14:38 AM (2 years ago)
Author:
SergeyBiryukov
Message:

Accessibility: Improve settings tables and forms after [45403].

  • adds role="presentation" to the edit comment table
  • removes a few pointless <fieldset> elements
  • adds a few missing <label> elements
  • adds the CSS class class="td-full" to table rows spanning to multiple cells
  • adds explicit scope="row" attribute to the table headers in options-permalink.php: this table is better communicated as data table
  • uses consistent label association in the "Privacy Settings" page
  • in the installation page "Set up your database connection": associates descriptions to their inout fields using aria-describedby
  • improves the link to gravatar.com in the user-edit.php page

Props afercia.
Merges [45416] to the 5.2 branch.
See #46899.
Fixes #47390.

Location:
branches/5.2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • branches/5.2

  • branches/5.2/src/wp-admin/privacy.php

    r44971 r45835  
    192192
    193193    <hr>
    194     <table class="form-table tools-privacy-policy-page">
     194    <table class="form-table tools-privacy-policy-page" role="presentation">
    195195        <tr>
    196             <th scope="row">
     196            <th scope="row"><label for="page_for_privacy_policy">
    197197                <?php
    198198                if ( $privacy_policy_page_exists ) {
     
    202202                }
    203203                ?>
    204             </th>
     204            </label></th>
    205205            <td>
    206206                <?php
     
    219219                    ?>
    220220                    <form method="post" action="">
    221                         <label for="page_for_privacy_policy">
    222                             <?php _e( 'Select an existing page:' ); ?>
    223                         </label>
    224221                        <input type="hidden" name="action" value="set-privacy-page" />
    225222                        <?php
Note: See TracChangeset for help on using the changeset viewer.