Changeset 45835 for branches/5.2/src/wp-admin/setup-config.php

Timestamp:

08/19/2019 04:14:38 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Accessibility: Improve settings tables and forms after [45403].

• adds role="presentation" to the edit comment table
• removes a few pointless <fieldset> elements
• adds a few missing <label> elements
• adds the CSS class class="td-full" to table rows spanning to multiple cells
• adds explicit scope="row" attribute to the table headers in options-permalink.php: this table is better communicated as data table
• uses consistent label association in the "Privacy Settings" page
• in the installation page "Set up your database connection": associates descriptions to their inout fields using aria-describedby
• improves the link to gravatar.com in the user-edit.php page

Props afercia.
Merges [45416] to the 5.2 branch.
See #46899.
Fixes #47390.

Location:

branches/5.2

Files:

• . (modified) (1 prop)
• src/wp-admin/setup-config.php (modified) (2 diffs)

branches/5.2/src/wp-admin/setup-config.php

@@ -211 +211 @@
         <tr>
             <th scope="row"><label for="dbname"><?php _e( 'Database Name' ); ?></label></th>
-            <td><input name="dbname" id="dbname" type="text" size="25" value="wordpress"<?php echo $autofocus; ?>/></td>
-            <td><?php _e( 'The name of the database you want to use with WordPress.' ); ?></td>
+            <td><input name="dbname" id="dbname" type="text" aria-describedby="dbname-desc" size="25" value="wordpress"<?php echo $autofocus; ?>/></td>
+            <td id="dbname-desc"><?php _e( 'The name of the database you want to use with WordPress.' ); ?></td>
         </tr>
         <tr>
             <th scope="row"><label for="uname"><?php _e( 'Username' ); ?></label></th>
-            <td><input name="uname" id="uname" type="text" size="25" value="<?php echo htmlspecialchars( _x( 'username', 'example username' ), ENT_QUOTES ); ?>" /></td>
-            <td><?php _e( 'Your database username.' ); ?></td>
+            <td><input name="uname" id="uname" type="text" aria-describedby="uname-desc" size="25" value="<?php echo htmlspecialchars( _x( 'username', 'example username' ), ENT_QUOTES ); ?>" /></td>
+            <td id="uname-desc"><?php _e( 'Your database username.' ); ?></td>
         </tr>
         <tr>
             <th scope="row"><label for="pwd"><?php _e( 'Password' ); ?></label></th>
-            <td><input name="pwd" id="pwd" type="text" size="25" value="<?php echo htmlspecialchars( _x( 'password', 'example password' ), ENT_QUOTES ); ?>" autocomplete="off" /></td>
-            <td><?php _e( 'Your database password.' ); ?></td>
+            <td><input name="pwd" id="pwd" type="text" aria-describedby="pwd-desc" size="25" value="<?php echo htmlspecialchars( _x( 'password', 'example password' ), ENT_QUOTES ); ?>" autocomplete="off" /></td>
+            <td id="pwd-desc"><?php _e( 'Your database password.' ); ?></td>
         </tr>
         <tr>
             <th scope="row"><label for="dbhost"><?php _e( 'Database Host' ); ?></label></th>
-            <td><input name="dbhost" id="dbhost" type="text" size="25" value="localhost" /></td>
-            <td>
+            <td><input name="dbhost" id="dbhost" type="text" aria-describedby="dbhost-desc" size="25" value="localhost" /></td>
+            <td id="dbhost-desc">
             <?php
                 /* translators: %s: localhost */
@@ -236 +236 @@
         <tr>
             <th scope="row"><label for="prefix"><?php _e( 'Table Prefix' ); ?></label></th>
-            <td><input name="prefix" id="prefix" type="text" value="wp_" size="25" /></td>
-            <td><?php _e( 'If you want to run multiple WordPress installations in a single database, change this.' ); ?></td>
+            <td><input name="prefix" id="prefix" type="text" aria-describedby="prefix-desc" value="wp_" size="25" /></td>
+            <td id="prefix-desc"><?php _e( 'If you want to run multiple WordPress installations in a single database, change this.' ); ?></td>
         </tr>
     </table>