Changeset 45841

Timestamp:

08/19/2019 04:33:43 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Media: Reduces the bulk media options to have one primary button.

This fixes where 2 primary buttons were showing for bulk actions within media trash.

Props garrett-eclipse, afercia, ianbelanger, SergeyBiryukov, karmatosed.
Merges [45701] to the 5.2 branch.
Fixes #46757, #46758

Location:

branches/5.2

Files:

• . (modified) (1 prop)
• src/js/media/views/attachments/browser.js (modified) (2 diffs)
• src/js/media/views/button/delete-selected.js (modified) (1 diff)
• src/wp-includes/css/buttons.css (modified) (1 diff)

branches/5.2/src/js/media/views/attachments/browser.js

@@ -190 +190 @@
                 text: mediaTrash ? l10n.trashSelected : l10n.deletePermanently,
                 controller: this.controller,
-                priority: -60,
+                priority: -80,
                 click: function() {
                     var changed = [], removed = [],
@@ -246 +246 @@
                 this.toolbar.set( 'deleteSelectedPermanentlyButton', new wp.media.view.DeleteSelectedPermanentlyButton({
                     filters: Filters,
-                    style: 'primary',
+                    style: 'link button-link-delete',
                     disabled: true,
                     text: l10n.deletePermanently,

branches/5.2/src/js/media/views/button/delete-selected.js

@@ -23 +23 @@
         }
         this.controller.on( 'selection:toggle', this.toggleDisabled, this );
+        this.controller.on( 'select:activate', this.toggleDisabled, this );
     },
 

branches/5.2/src/wp-includes/css/buttons.css

@@ -225 +225 @@
 .wp-core-ui .button-link-delete:focus {
     color: #dc3232;
+    background: transparent;
+}
+
+.wp-core-ui .button-link-delete:disabled {
+    /* overrides the default buttons disabled background */
+    background: transparent !important;
 }