Changeset 45870 for branches/5.2

Timestamp:

08/21/2019 12:28:51 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Customizer: Trim whitespace from custom link URLs.

This complements a similar fix for the Menus screen in [45655].

Props donmhico, audrasjb.
Merges [45869] to the 5.2 branch.
Fixes #47888. See #47723.

Location:

branches/5.2

Files:

• . (modified) (1 prop)
• src/js/_enqueues/lib/nav-menu.js (modified) (1 diff)
• src/js/_enqueues/wp/customize/nav-menus.js (modified) (3 diffs)

branches/5.2/src/js/_enqueues/lib/nav-menu.js

@@ -945 +945 @@
 
         addCustomLink : function( processMethod ) {
-            var url = $('#custom-menu-item-url').val(),
+            var url = $('#custom-menu-item-url').val().trim(),
                 label = $('#custom-menu-item-name').val();
 

branches/5.2/src/js/_enqueues/wp/customize/nav-menus.js

@@ -545 +545 @@
                 itemName = $( '#custom-menu-item-name' ),
                 itemUrl = $( '#custom-menu-item-url' ),
+                url = itemUrl.val().trim(),
                 urlRegex;
 
@@ -568 +569 @@
                 itemName.addClass( 'invalid' );
                 return;
-            } else if ( ! urlRegex.test( itemUrl.val() ) ) {
+            } else if ( ! urlRegex.test( url ) ) {
                 itemUrl.addClass( 'invalid' );
                 return;
@@ -575 +576 @@
             menuItem = {
                 'title': itemName.val(),
-                'url': itemUrl.val(),
+                'url': url,
                 'type': 'custom',
                 'type_label': api.Menus.data.l10n.custom_label,