Changeset 45873 for trunk/src/wp-admin/includes/template.php

Timestamp:

08/22/2019 12:21:49 AM (7 years ago)

Author:

SergeyBiryukov

Message:

Administration: Adjust [45814] to address a backward compatibility issue for plugins passing multiple CSS classes to add_settings_error().

Only add the notice- prefix for error, success, warning, info CSS classes, keep other classes as is.

Add unit tests for settings_errors().

Props afercia, SergeyBiryukov.
Fixes #44941.

File:

• trunk/src/wp-admin/includes/template.php (modified) (1 diff)

trunk/src/wp-admin/includes/template.php

@@ -1815 +1815 @@
         }
 
+        if ( in_array( $details['type'], array( 'error', 'success', 'warning', 'info' ) ) ) {
+            $details['type'] = 'notice-' . $details['type'];
+        }
+
         $css_id    = sprintf(
             'setting-error-%s',
-            sanitize_html_class( $details['code'] )
+            esc_attr( $details['code'] )
         );
         $css_class = sprintf(
-            'notice notice-%s settings-error is-dismissible',
-            sanitize_html_class( $details['type'] )
+            'notice %s settings-error is-dismissible',
+            esc_attr( $details['type'] )
         );