Changeset 45893 for trunk/tests/phpunit/tests/term/wpUniqueTermSlug.php

Timestamp:

08/26/2019 03:18:40 PM (6 years ago)

Author:

boonebgorges

Message:

Taxonomy: Fix unique-slug check for terms with parents.

wp_unique_term_slug() appends numeric suffixes when the requested slug is
already in use by a sibling term. Changes introduced in [32837] inadvertently
caused this suffixing to be skipped in cases where the requested slug is
suffixed with the parent slug, so that it became possible to have two terms
childslug-parentslug underneath to the same parentslug. We fix this
regression by ensuring that the numeric-suffix routine runs in all cases.

Props yashar_hv, saskak, dlh.
Fixes #46431.

File:

• trunk/tests/phpunit/tests/term/wpUniqueTermSlug.php (modified) (1 diff)

trunk/tests/phpunit/tests/term/wpUniqueTermSlug.php

@@ -128 +128 @@
         $this->assertEquals( 'bar-2', $actual );
     }
+
+    /**
+     * @ticket 46431
+     */
+    public function test_duplicate_parent_suffixed_slug_should_get_numeric_suffix() {
+        $t1 = self::factory()->term->create(
+            array(
+                'taxonomy' => 'wptests_tax2',
+                'name'     => 'Animal',
+                'slug'     => 'animal',
+            )
+        );
+
+        $t2 = self::factory()->term->create(
+            array(
+                'taxonomy' => 'wptests_tax2',
+                'name'     => 'Dog',
+                'slug'     => 'dog',
+            )
+        );
+
+        $t3 = self::factory()->term->create(
+            array(
+                'taxonomy' => 'wptests_tax2',
+                'name'     => 'Cat',
+                'slug'     => 'dog-animal',
+                'parent'   => $t1,
+            )
+        );
+
+        $t4 = self::factory()->term->create(
+            array(
+                'taxonomy' => 'wptests_tax2',
+                'name'     => 'Giraffe',
+                'slug'     => 'giraffe',
+                'parent'   => $t1,
+            )
+        );
+
+        $term = get_term( $t4 );
+
+        $slug = wp_unique_term_slug( 'dog', $term );
+
+        $this->assertSame( 'dog-animal-2', $slug );
+    }
 }