Changeset 45903 for trunk/src/wp-includes/rest-api/fields/class-wp-rest-meta-fields.php

Timestamp:

08/28/2019 03:07:03 AM (5 years ago)

Author:

kadamwhite

Message:

REST API: Only cast scalar types to string when comparing new & old meta values.

Newly-supported array and object meta types should not be cast to strings.

Props TimothyBlynJacobs, caercam.
Fixes #47928.

File:

• trunk/src/wp-includes/rest-api/fields/class-wp-rest-meta-fields.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/fields/class-wp-rest-meta-fields.php

@@ -351 +351 @@
         $old_value = get_metadata( $meta_type, $object_id, $meta_key );
         $subtype   = get_object_subtype( $meta_type, $object_id );
+        $args      = $this->get_registered_fields()[ $meta_key ];
 
         if ( 1 === count( $old_value ) ) {
-            if ( (string) sanitize_meta( $meta_key, $value, $meta_type, $subtype ) === $old_value[0] ) {
+            $sanitized = sanitize_meta( $meta_key, $value, $meta_type, $subtype );
+
+            if ( in_array( $args['type'], array( 'string', 'number', 'integer', 'boolean' ), true ) ) {
+                // The return value of get_metadata will always be a string for scalar types.
+                $sanitized = (string) $sanitized;
+            }
+
+            if ( $sanitized === $old_value[0] ) {
                 return true;
             }