Changeset 45904 for trunk/src/wp-admin/includes/class-wp-site-health.php

Timestamp:

08/28/2019 03:07:59 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Site Health: Standardize on SELECT VERSION() query for checking the database server version, due to the MariaDB version declaration potentially causing issues in production environments.

Partially reverts [45691].

Props Clorith.
Fixes #47738.

File:

• trunk/src/wp-admin/includes/class-wp-site-health.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -133 +133 @@
         global $wpdb;
 
-        if ( method_exists( $wpdb, 'db_version' ) ) {
-            if ( $wpdb->use_mysqli ) {
-                // phpcs:ignore WordPress.DB.RestrictedFunctions.mysql_mysqli_get_server_info
-                $mysql_server_type = mysqli_get_server_info( $wpdb->dbh );
-            } else {
-                // phpcs:ignore WordPress.DB.RestrictedFunctions.mysql_mysql_get_server_info
-                $mysql_server_type = mysql_get_server_info( $wpdb->dbh );
-            }
-
-            $this->mysql_server_version = $wpdb->db_version();
-        }
+        if ( $wpdb->use_mysqli ) {
+            // phpcs:ignore WordPress.DB.RestrictedFunctions.mysql_mysqli_get_server_info
+            $mysql_server_type = mysqli_get_server_info( $wpdb->dbh );
+        } else {
+            // phpcs:ignore WordPress.DB.RestrictedFunctions.mysql_mysql_get_server_info
+            $mysql_server_type = mysql_get_server_info( $wpdb->dbh );
+        }
+
+        $this->mysql_server_version = $wpdb->get_var( 'SELECT VERSION()' );
 
         $this->health_check_mysql_rec_version = '5.6';