Changeset 45906

Timestamp:

08/29/2019 02:09:42 AM (5 years ago)

Author:

SergeyBiryukov

Message:

XML-RPC: Make sure editing a draft post with wp.editPost does not unintentionally cause its published date to be set.

Props redsweater.
Fixes #45322.

Location:

trunk

Files:

• src/wp-includes/class-wp-xmlrpc-server.php (modified) (1 diff)
• tests/phpunit/tests/xmlrpc/wp/editPost.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-xmlrpc-server.php

@@ -1709 +1709 @@
         }
 
+        /*
+         * If the API client did not provide post_date, then we must not perpetuate the value that was
+         * stored in the database, or it will appear to be an intentional edit. Conveying it here as if
+         * it was coming from the API client will cause an otherwise zeroed out post_date_gmt to get set
+         * with the value that was originally stored in the database when the draft was created.
+         */
+        if ( ! isset( $content_struct['post_date'] ) ) {
+            unset( $post['post_date'] );
+        }
+
         $this->escape( $post );
         $merged_content_struct = array_merge( $post, $content_struct );

trunk/tests/phpunit/tests/xmlrpc/wp/editPost.php

@@ -497 +497 @@
         $this->assertEquals( $future_date_string, $after->post_date );
     }
+
+    /**
+     * @ticket 45322
+     */
+    function test_draft_not_assigned_published_date() {
+        $editor_id = $this->make_user_by_role( 'editor' );
+
+        // Start with a draft post, confirming its post_date_gmt is "zero".
+        $post    = array(
+            'post_title'  => 'Test',
+            'post_status' => 'draft',
+        );
+        $post_id = $this->myxmlrpcserver->wp_newPost( array( 1, 'editor', 'editor', $post ) );
+
+        $before  = get_post( $post_id );
+        $this->assertEquals( '0000-00-00 00:00:00', $before->post_date_gmt );
+
+        // Edit the post without specifying any dates.
+        $new_post_content = array(
+            'ID'         => $post_id,
+            'post_title' => 'Updated',
+        );
+
+        $this->myxmlrpcserver->wp_editPost( array( 1, 'editor', 'editor', $post_id, $new_post_content ) );
+
+        // The published date should still be zero.
+        $after = get_post( $post_id );
+        $this->assertEquals( '0000-00-00 00:00:00', $after->post_date_gmt );
+    }
 }