Changeset 45909 for trunk/src/wp-includes/functions.php

Timestamp:

08/29/2019 07:52:43 AM (6 years ago)

Author:

mikeschroder

Message:

Administration: Output valid HTML when wp_die() is called.

To better support HTML and string calls to wp_die() without
outputting invalid HTML, wraps error messages in <div> rather than <p>.

Adds .wp-die-message CSS class for styling.

Props dinhtungdu, jeremyfelt, audrasjb, SergeyBiryukov, afercia, audrasjb, noisysocks.
Fixes #47580.

File:

• trunk/src/wp-includes/functions.php (modified) (2 diffs)

trunk/src/wp-includes/functions.php

@@ -3192 +3192 @@
             );
             $message = "<ul>\n\t\t<li>" . join( "</li>\n\t\t<li>", $message ) . "</li>\n\t</ul>";
-        } else {
-            $message = "<p>$message</p>";
-        }
+        }
+
+        $message = sprintf(
+            '<div class="wp-die-message">%s</div>',
+            $message
+        );
     }
 
@@ -3264 +3267 @@
             margin-top: 50px;
         }
-        #error-page p {
+        #error-page p,
+        #error-page .wp-die-message {
             font-size: 14px;
             line-height: 1.5;