Changeset 45914 for trunk/tests/phpunit/tests/date/dateI18n.php

Timestamp:

08/29/2019 11:17:30 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Date/Time: Restore the previous behavior of date_i18n() where invalid input would result in current time.

Make wp_date() return false on invalid timestamp input, for consistency with upstream PHP date() function.

Props Rarst.
Fixes #28636.

File:

• trunk/tests/phpunit/tests/date/dateI18n.php (modified) (2 diffs)

trunk/tests/phpunit/tests/date/dateI18n.php

@@ -6 +6 @@
  */
 class Tests_Date_I18n extends WP_UnitTestCase {
+
+    /**
+     * @ticket 28636
+     */
+    public function test_should_return_current_time_on_invalid_timestamp() {
+        $timezone = 'Europe/Kiev';
+        update_option( 'timezone_string', $timezone );
+
+        $datetime     = new DateTime( 'now', new DateTimeZone( $timezone ) );
+        $wp_timestamp = $datetime->getTimestamp() + $datetime->getOffset();
+
+        $this->assertEquals( $wp_timestamp, date_i18n( 'U', 'invalid' ), '', 5 );
+    }
+
     public function test_should_format_date() {
         $this->assertEquals( strtotime( gmdate( 'Y-m-d H:i:s' ) ), strtotime( date_i18n( 'Y-m-d H:i:s' ) ), 'The dates should be equal', 2 );
@@ -75 +89 @@
         $offset = $datetimezone->getOffset( new DateTime() ) / 3600;
         update_option( 'gmt_offset', $offset );
+
         $datetime = new DateTime( 'now', $datetimezone );
         $datetime = new DateTime( $datetime->format( 'P' ) );