WordPress.org

Make WordPress Core

Changeset 45919


Ignore:
Timestamp:
08/30/2019 06:57:51 PM (3 weeks ago)
Author:
SergeyBiryukov
Message:

Twenty Nineteen: Remove Baskerville Old Face from the font stack due to several shortcomings:

  • Being difficult to read due to its mix of thin and thick strokes.
  • Having poor language/extended character support.
  • Not having other weights/styles (bold, italic, etc) and relying on browser approximations of those variants.

The next fonts down the stack (Garamond and Times) are more properly aligned to the appearance of the top-level serif font in the stack (Hoefler Text), and work better in its place.

Props kjellr, Rarst, justintadlock.
Fixes #45881.

Location:
trunk/src/wp-content/themes/twentynineteen
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-content/themes/twentynineteen/sass/variables-site/_fonts.scss

    r44657 r45919  
    1515// Font and typographic variables
    1616
    17 $font__body: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     17$font__body: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    1818$font__heading: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif;
    1919$font__fallbacks: (
  • trunk/src/wp-content/themes/twentynineteen/style-editor.css

    r45761 r45919  
    612612body {
    613613  font-size: 22px;
    614   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     614  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    615615  line-height: 1.8;
    616616  color: #111;
     
    793793/** === Default Appender === */
    794794.editor-default-block-appender .editor-default-block-appender__content {
    795   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     795  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    796796  font-size: 22px;
    797797}
     
    11981198
    11991199.wp-block-categories ul ul > li > a::before {
    1200   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     1200  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    12011201  font-weight: normal;
    12021202  content: "– " counters(submenu, "– ", none);
  • trunk/src/wp-content/themes/twentynineteen/style-rtl.css

    r45897 r45919  
    22132213  -moz-osx-font-smoothing: grayscale;
    22142214  color: #111;
    2215   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     2215  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    22162216  font-weight: 400;
    22172217  font-size: 1em;
     
    22272227textarea {
    22282228  color: #111;
    2229   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     2229  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    22302230  font-weight: 400;
    22312231  line-height: 1.8;
     
    22872287
    22882288.page-title {
    2289   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     2289  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    22902290}
    22912291
     
    31173117
    31183118.main-navigation .main-menu .menu-item-has-children:not(.off-canvas)[focus-within] > .sub-menu .sub-menu > li > a::before {
    3119   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     3119  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    31203120  font-weight: normal;
    31213121  content: "– " counters(submenu, "– ", none);
     
    31243124
    31253125.main-navigation .main-menu .menu-item-has-children:not(.off-canvas):focus-within > .sub-menu .sub-menu > li > a::before {
    3126   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     3126  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    31273127  font-weight: normal;
    31283128  content: "– " counters(submenu, "– ", none);
     
    32203220.main-navigation .main-menu .menu-item-has-children:not(.off-canvas):focus > .sub-menu .sub-menu > li > a::before,
    32213221.main-navigation .main-menu .menu-item-has-children.is-focused:not(.off-canvas) > .sub-menu .sub-menu > li > a::before {
    3222   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     3222  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    32233223  font-weight: normal;
    32243224  content: "– " counters(submenu, "– ", none);
     
    51455145.widget_recent_entries ul ul > li > a::before,
    51465146.widget_rss ul ul > li > a::before {
    5147   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     5147  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    51485148  font-weight: normal;
    51495149  content: "– " counters(submenu, "– ", none);
     
    55225522
    55235523.entry .entry-content .wp-block-categories ul > li > a::before {
    5524   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     5524  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    55255525  font-weight: normal;
    55265526  content: "– " counters(submenu, "– ", none);
     
    55785578
    55795579.entry .entry-content .wp-block-verse {
    5580   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     5580  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    55815581  font-size: 22px;
    55825582  line-height: 1.8;
  • trunk/src/wp-content/themes/twentynineteen/style.css

    r45897 r45919  
    22132213  -moz-osx-font-smoothing: grayscale;
    22142214  color: #111;
    2215   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     2215  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    22162216  font-weight: 400;
    22172217  font-size: 1em;
     
    22272227textarea {
    22282228  color: #111;
    2229   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     2229  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    22302230  font-weight: 400;
    22312231  line-height: 1.8;
     
    22872287
    22882288.page-title {
    2289   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     2289  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    22902290}
    22912291
     
    31173117
    31183118.main-navigation .main-menu .menu-item-has-children:not(.off-canvas)[focus-within] > .sub-menu .sub-menu > li > a::before {
    3119   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     3119  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    31203120  font-weight: normal;
    31213121  content: "– " counters(submenu, "– ", none);
     
    31243124
    31253125.main-navigation .main-menu .menu-item-has-children:not(.off-canvas):focus-within > .sub-menu .sub-menu > li > a::before {
    3126   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     3126  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    31273127  font-weight: normal;
    31283128  content: "– " counters(submenu, "– ", none);
     
    32203220.main-navigation .main-menu .menu-item-has-children:not(.off-canvas):focus > .sub-menu .sub-menu > li > a::before,
    32213221.main-navigation .main-menu .menu-item-has-children.is-focused:not(.off-canvas) > .sub-menu .sub-menu > li > a::before {
    3222   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     3222  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    32233223  font-weight: normal;
    32243224  content: "– " counters(submenu, "– ", none);
     
    51515151.widget_recent_entries ul ul > li > a::before,
    51525152.widget_rss ul ul > li > a::before {
    5153   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     5153  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    51545154  font-weight: normal;
    51555155  content: "– " counters(submenu, "– ", none);
     
    55345534
    55355535.entry .entry-content .wp-block-categories ul > li > a::before {
    5536   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     5536  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    55375537  font-weight: normal;
    55385538  content: "– " counters(submenu, "– ", none);
     
    55905590
    55915591.entry .entry-content .wp-block-verse {
    5592   font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif;
     5592  font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
    55935593  font-size: 22px;
    55945594  line-height: 1.8;
Note: See TracChangeset for help on using the changeset viewer.