Changeset 45926 for trunk/src/wp-admin/includes/ajax-actions.php

Timestamp:

09/01/2019 05:12:43 PM (5 years ago)

Author:

SergeyBiryukov

Message:

I18N: Improve translator comments.

• Add missing translator comments.
• Fix placement of some translator comments. Translator comments should be on the line directly above the line containing the translation function call for optimal compatibility with various .pot file generation tools. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translator comments.

Includes minor code layout fixes.

Polyglots, rejoice! All WordPress core files now have translator comments for all strings with placeholders!

Props jrf, subrataemfluence, GaryJ, webdados, Dency, swissspidy, alvarogois, marcomartins, mihaiiceyro, vladwtz, niq1982, flipkeijzer, michielatyoast, chandrapatel, thrijith, joshuanoyce, FesoVik, tessak22, bhaktirajdev, cleancoded, dhavalkasvala, garrett-eclipse, bibliofille, socalchristina, priyankkpatel, 5hel2l2y, adamsilverstein, JeffPaul, pierlo, SergeyBiryukov.
Fixes #44360.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (8 diffs)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -315 +315 @@
     foreach ( $users as $user ) {
         $return[] = array(
-            /* translators: 1: user_login, 2: user_email */
+            /* translators: 1: user login, 2: user email address */
             'label' => sprintf( _x( '%1$s (%2$s)', 'user autocomplete result' ), $user->user_login, $user->user_email ),
             'value' => $user->$field,
@@ -455 +455 @@
                     'in_moderation'        => $counts->moderated,
                     'i18n_comments_text'   => sprintf(
-                        /* translators: %s: number of comments approved */
+                        /* translators: %s: number of comments */
                         _n( '%s Comment', '%s Comments', $counts->approved ),
                         number_format_i18n( $counts->approved )
                     ),
                     'i18n_moderation_text' => sprintf(
-                        /* translators: %s: number of comments in moderation */
+                        /* translators: %s: number of comments */
                         _n( '%s Comment in moderation', '%s Comments in moderation', $counts->moderated ),
                         number_format_i18n( $counts->moderated )
@@ -527 +527 @@
                 'in_moderation'        => $counts->moderated,
                 'i18n_moderation_text' => sprintf(
-                    /* translators: %s: number of comments in moderation */
+                    /* translators: %s: number of comments */
                     _n( '%s Comment in moderation', '%s Comments in moderation', $counts->moderated ),
                     number_format_i18n( $counts->moderated )
@@ -914 +914 @@
             array(
                 'what' => 'comment',
-                /* translators: %d: comment ID */
-                'id'   => new WP_Error( 'invalid_comment', sprintf( __( 'Comment %d does not exist' ), $id ) ),
+                'id'   => new WP_Error(
+                    'invalid_comment',
+                    /* translators: %d: comment ID */
+                    sprintf( __( 'Comment %d does not exist' ), $id )
+                ),
             )
         );
@@ -1302 +1305 @@
         'in_moderation'        => $counts->moderated,
         'i18n_comments_text'   => sprintf(
-            /* translators: %s: number of comments approved */
+            /* translators: %s: number of comments */
             _n( '%s Comment', '%s Comments', $counts->approved ),
             number_format_i18n( $counts->approved )
         ),
         'i18n_moderation_text' => sprintf(
-            /* translators: %s: number of comments in moderation */
+            /* translators: %s: number of comments */
             _n( '%s Comment in moderation', '%s Comments in moderation', $counts->moderated ),
             number_format_i18n( $counts->moderated )
@@ -1915 +1918 @@
         $last_user_name = $last_user ? $last_user->display_name : __( 'Someone' );
 
-        /* translators: %s: user who is currently editing the post */
+        /* translators: %s: user's display name */
         $msg_template = __( 'Saving is disabled: %s is currently editing this post.' );
+
         if ( $_POST['post_type'] == 'page' ) {
-            /* translators: %s: user who is currently editing the page */
+            /* translators: %s: user's display name */
             $msg_template = __( 'Saving is disabled: %s is currently editing this page.' );
         }
@@ -2627 +2631 @@
     if ( $last_id ) {
         $last_user = get_userdata( $last_id );
-        /* translators: 1: display_name of last user, 2: date of last edit, 3: time of last edit. */
+        /* translators: 1: user's display name, 2: date of last edit, 3: time of last edit. */
         $last_edited = sprintf( __( 'Last edited by %1$s on %2$s at %3$s' ), esc_html( $last_user->display_name ), $last_date, $last_time );
     } else {
@@ -3481 +3485 @@
             array(
                 'type'    => 'not-embeddable',
-                /* translators: %s: URL which cannot be embedded, between code tags */
+                /* translators: %s: URL that could not be embedded */
                 'message' => sprintf( __( '%s failed to embed.' ), '<code>' . esc_html( $url ) . '</code>' ),
             )