Changeset 45926 for trunk/src/wp-admin/includes/class-plugin-installer-skin.php

Timestamp:

09/01/2019 05:12:43 PM (5 years ago)

Author:

SergeyBiryukov

Message:

I18N: Improve translator comments.

• Add missing translator comments.
• Fix placement of some translator comments. Translator comments should be on the line directly above the line containing the translation function call for optimal compatibility with various .pot file generation tools. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translator comments.

Includes minor code layout fixes.

Polyglots, rejoice! All WordPress core files now have translator comments for all strings with placeholders!

Props jrf, subrataemfluence, GaryJ, webdados, Dency, swissspidy, alvarogois, marcomartins, mihaiiceyro, vladwtz, niq1982, flipkeijzer, michielatyoast, chandrapatel, thrijith, joshuanoyce, FesoVik, tessak22, bhaktirajdev, cleancoded, dhavalkasvala, garrett-eclipse, bibliofille, socalchristina, priyankkpatel, 5hel2l2y, adamsilverstein, JeffPaul, pierlo, SergeyBiryukov.
Fixes #44360.

File:

• trunk/src/wp-admin/includes/class-plugin-installer-skin.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-plugin-installer-skin.php

@@ -43 +43 @@
     public function before() {
         if ( ! empty( $this->api ) ) {
-            /* translators: 1: name of API, 2: version of API */
-            $this->upgrader->strings['process_success'] = sprintf( __( 'Successfully installed the plugin <strong>%1$s %2$s</strong>.' ), $this->api->name, $this->api->version );
+            $this->upgrader->strings['process_success'] = sprintf(
+                /* translators: 1: plugin name, 2: plugin version */
+                __( 'Successfully installed the plugin <strong>%1$s %2$s</strong>.' ),
+                $this->api->name,
+                $this->api->version
+            );
         }
     }
@@ -58 +62 @@
 
         if ( 'import' == $from ) {
-            $install_actions['activate_plugin'] = '<a class="button button-primary" href="' . wp_nonce_url( 'plugins.php?action=activate&amp;from=import&amp;plugin=' . urlencode( $plugin_file ), 'activate-plugin_' . $plugin_file ) . '" target="_parent">' . __( 'Activate Plugin &amp; Run Importer' ) . '</a>';
+            $install_actions['activate_plugin'] = sprintf(
+                '<a class="button button-primary" href="%s" target="_parent">%s</a>',
+                wp_nonce_url( 'plugins.php?action=activate&amp;from=import&amp;plugin=' . urlencode( $plugin_file ), 'activate-plugin_' . $plugin_file ),
+                __( 'Activate Plugin &amp; Run Importer' )
+            );
         } elseif ( 'press-this' == $from ) {
-            $install_actions['activate_plugin'] = '<a class="button button-primary" href="' . wp_nonce_url( 'plugins.php?action=activate&amp;from=press-this&amp;plugin=' . urlencode( $plugin_file ), 'activate-plugin_' . $plugin_file ) . '" target="_parent">' . __( 'Activate Plugin &amp; Return to Press This' ) . '</a>';
+            $install_actions['activate_plugin'] = sprintf(
+                '<a class="button button-primary" href="%s" target="_parent">%s</a>',
+                wp_nonce_url( 'plugins.php?action=activate&amp;from=press-this&amp;plugin=' . urlencode( $plugin_file ), 'activate-plugin_' . $plugin_file ),
+                __( 'Activate Plugin &amp; Return to Press This' )
+            );
         } else {
-            $install_actions['activate_plugin'] = '<a class="button button-primary" href="' . wp_nonce_url( 'plugins.php?action=activate&amp;plugin=' . urlencode( $plugin_file ), 'activate-plugin_' . $plugin_file ) . '" target="_parent">' . __( 'Activate Plugin' ) . '</a>';
+            $install_actions['activate_plugin'] = sprintf(
+                '<a class="button button-primary" href="%s" target="_parent">%s</a>',
+                wp_nonce_url( 'plugins.php?action=activate&amp;plugin=' . urlencode( $plugin_file ), 'activate-plugin_' . $plugin_file ),
+                __( 'Activate Plugin' )
+            );
         }
 
         if ( is_multisite() && current_user_can( 'manage_network_plugins' ) ) {
-            $install_actions['network_activate'] = '<a class="button button-primary" href="' . wp_nonce_url( 'plugins.php?action=activate&amp;networkwide=1&amp;plugin=' . urlencode( $plugin_file ), 'activate-plugin_' . $plugin_file ) . '" target="_parent">' . __( 'Network Activate' ) . '</a>';
+            $install_actions['network_activate'] = sprintf(
+                '<a class="button button-primary" href="%s" target="_parent">%s</a>',
+                wp_nonce_url( 'plugins.php?action=activate&amp;networkwide=1&amp;plugin=' . urlencode( $plugin_file ), 'activate-plugin_' . $plugin_file ),
+                __( 'Network Activate' )
+            );
             unset( $install_actions['activate_plugin'] );
         }
 
         if ( 'import' == $from ) {
-            $install_actions['importers_page'] = '<a href="' . admin_url( 'import.php' ) . '" target="_parent">' . __( 'Return to Importers' ) . '</a>';
+            $install_actions['importers_page'] = sprintf(
+                '<a href="%s" target="_parent">%s</a>',
+                admin_url( 'import.php' ),
+                __( 'Return to Importers' )
+            );
         } elseif ( $this->type == 'web' ) {
-            $install_actions['plugins_page'] = '<a href="' . self_admin_url( 'plugin-install.php' ) . '" target="_parent">' . __( 'Return to Plugin Installer' ) . '</a>';
+            $install_actions['plugins_page'] = sprintf(
+                '<a href="%s" target="_parent">%s</a>',
+                self_admin_url( 'plugin-install.php' ),
+                __( 'Return to Plugin Installer' )
+            );
         } elseif ( 'upload' == $this->type && 'plugins' == $from ) {
-            $install_actions['plugins_page'] = '<a href="' . self_admin_url( 'plugin-install.php' ) . '">' . __( 'Return to Plugin Installer' ) . '</a>';
+            $install_actions['plugins_page'] = sprintf(
+                '<a href="%s">%s</a>',
+                self_admin_url( 'plugin-install.php' ),
+                __( 'Return to Plugin Installer' )
+            );
         } else {
-            $install_actions['plugins_page'] = '<a href="' . self_admin_url( 'plugins.php' ) . '" target="_parent">' . __( 'Return to Plugins page' ) . '</a>';
+            $install_actions['plugins_page'] = sprintf(
+                '<a href="%s" target="_parent">%s</a>',
+                self_admin_url( 'plugins.php' ),
+                __( 'Return to Plugins page' )
+            );
         }